Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/4339#discussion_r24034165
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameImpl.scala
---
@@ -141,7 +141,7 @@ private[sql] class DataFrameImpl protected[sql](
}
override def orderBy(sortCol: String, sortCols: String*): DataFrame = {
- sort(sortCol, sortCols :_*)
+ orderBy(sortCol, sortCols :_*)
--- End diff --
Can you put the real types here instead? (i.e. `sortCols: String*`) as the
flow here is super confusing. Also I'd have most versions call `sort(sortCol:
String, sortCols: String*)`, where the actual work is done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
