maropu commented on a change in pull request #26267:
[SPARK-29008][SQL][FOLLOW-UP] Checks correct param lengths of split methods
URL: https://github.com/apache/spark/pull/26267#discussion_r339297946
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
##########
@@ -1050,7 +1050,10 @@ class CodegenContext extends Logging {
}
val codes = if (commonExprVals.map(_.code.length).sum >
SQLConf.get.methodSplitThreshold) {
- if (commonExprs.map(calculateParamLength).forall(isValidParamLength)) {
+ val inputVarsForAllFuncs = commonExprs.map { expr =>
+ getLocalInputVariableValues(this, expr.head).toSeq
+ }
+ if
(inputVarsForAllFuncs.map(calculateParamLengthFromExprValues).forall(isValidParamLength))
{
Review comment:
@viirya @cloud-fan sorry, but I found my mistake made in SPARK-29008...
Could you check?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
