planga82 commented on a change in pull request #26182: [SPARK-29523][SQL] SHOW
COLUMNS should do multi-catalog resolution.
URL: https://github.com/apache/spark/pull/26182#discussion_r339330108
##########
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -196,8 +196,10 @@ statement
LIKE pattern=STRING partitionSpec?
#showTable
| SHOW TBLPROPERTIES table=tableIdentifier
('(' key=tablePropertyKey ')')?
#showTblProperties
- | SHOW COLUMNS (FROM | IN) tableIdentifier
- ((FROM | IN) db=errorCapturingIdentifier)?
#showColumns
+ | SHOW COLUMNS (FROM | IN)
+ ((tableName=errorCapturingIdentifier
+ (FROM | IN) namespace=multipartIdentifier) |
+ table=multipartIdentifier)
#showColumns
Review comment:
@cloud-fan
I reviewed the test cases and code and I arrived the conclusion that
something like that is permitted:
SHOW COLUMNS FROM db1.t1 IN db1
So I have change this pull request to allow it and don't break tests in
other parts.
Are you agree with it?
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
