skonto commented on a change in pull request #26161: [SPARK-27900][CORE][K8s]
Add `spark.driver.killOnOOMError` flag in cluster mode
URL: https://github.com/apache/spark/pull/26161#discussion_r339359651
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -111,6 +111,10 @@ package object config {
.booleanConf
.createWithDefault(false)
+ private[spark] val KILL_ON_OOM_ERROR =
ConfigBuilder("spark.driver.killOnOOMError")
+ .doc("Whether to kill the driver on an oom error in cluster mode.")
+ .booleanConf.createWithDefault(true)
Review comment:
Yes we agreed to change the default, we want to fail by default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
