dongjoon-hyun commented on a change in pull request #25870: [SPARK-27936][K8S]
Support python deps
URL: https://github.com/apache/spark/pull/25870#discussion_r339387138
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/DriverCommandFeatureStep.scala
##########
@@ -73,7 +76,9 @@ private[spark] class DriverCommandFeatureStep(conf:
KubernetesDriverConf)
.withValue(conf.get(PYSPARK_MAJOR_PYTHON_VERSION))
.build())
- val pythonContainer = baseDriverContainer(pod, res)
+ // re-write primary resource to be the remote one and upload the related
file
+ val newResName = KubernetesUtils.renameMainAppResource(res,
Some(conf.sparkConf), false)
Review comment:
We recommend the following stye.
```scala
- val newResName = KubernetesUtils.renameMainAppResource(res,
Some(conf.sparkConf), false)
+ val newResName = KubernetesUtils.renameMainAppResource(res,
Some(conf.sparkConf), isJava = false)
```
The above is an example. When we rename `isJava`, we should change here
together.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
