HyukjinKwon commented on a change in pull request #26243: Prepare Spark release
v3.0.0-preview-rc1
URL: https://github.com/apache/spark/pull/26243#discussion_r339388097
##########
File path: R/pkg/R/sparkR.R
##########
@@ -334,17 +334,6 @@ sparkR.session <- function(
assign(".sparkRsession", sparkSession, envir = .sparkREnv)
}
- # Check if version number of SparkSession matches version number of SparkR
package
- jvmVersion <- callJMethod(sparkSession, "version")
- # Remove -SNAPSHOT from jvm versions
- jvmVersionStrip <- gsub("-SNAPSHOT", "", jvmVersion)
- rPackageVersion <- paste0(packageVersion("SparkR"))
-
- if (jvmVersionStrip != rPackageVersion) {
- warning(paste("Version mismatch between Spark JVM and SparkR package. JVM
version was",
- jvmVersion, ", while R package version was",
rPackageVersion))
- }
-
sparkSession
Review comment:
Alright, I checked previous Spark preview
(https://archive.apache.org/dist/spark/spark-2.0.0-preview/):
```
Type: Package
Title: R frontend for Spark
Version: 2.0.0
Date: 2013-09-09
```
The version was 2.0.0. So I think we're fine with 3.0.0 since at least it's
consistent.
PySpark version was added as of Spark 2.1
(https://issues.apache.org/jira/browse/SPARK-18129). I think 3.0.0.dev0 makes
sense for now. Seems like we can increase it to dev1 later per PEP 440
(https://www.python.org/dev/peps/pep-0440/).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
