Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4066#discussion_r24045509
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
    @@ -596,7 +597,9 @@ private[spark] class TaskSetManager(
         removeRunningTask(tid)
         info.markFailed()
         val index = info.index
    -    copiesRunning(index) -= 1
    +    if (copiesRunning(index) >= 1) {
    --- End diff --
    
    @mccheah do you remember why you added this?  How do we get more task 
failures than copies running?  If this change was necessary, I wonder whether 
there's a bug elsewhere.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to