cloud-fan commented on a change in pull request #26134: [SPARK-29486][SQL]
CalendarInterval should have 3 fields: months, days and microseconds
URL: https://github.com/apache/spark/pull/26134#discussion_r339433234
##########
File path:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/CalendarInterval.java
##########
@@ -195,7 +194,7 @@ public static CalendarInterval fromDayTimeString(String s,
String from, String t
} else {
try {
int sign = m.group(1) != null && m.group(1).equals("-") ? -1 : 1;
- long days = m.group(2) == null ? 0 : toLongWithRange("day", m.group(3),
+ int days = m.group(2) == null ? 0 : (int) toLongWithRange("day",
m.group(3),
Review comment:
This is OK here, we call `toLongWithRange` with `Integer.MAX_VALUE` so it's
safe to cast to int.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
