srowen commented on a change in pull request #26177: [SPARK-29520][SS] Fix
checks of negative intervals
URL: https://github.com/apache/spark/pull/26177#discussion_r339563624
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/IntervalUtils.scala
##########
@@ -119,4 +121,32 @@ object IntervalUtils {
case _: IllegalArgumentException => null
}
}
+
+ /**
+ * Gets interval duration
+ *
+ * @param cal - the interval to get duration
+ * @param targetUnit - time units of the result
+ * @param daysPerMonth - the number of days per one month
+ * @return duration in the specified time units
+ */
+ def getDuration(
+ cal: CalendarInterval,
+ targetUnit: TimeUnit,
+ daysPerMonth: Int = 31): Long = {
+ val monthsDuration = Math.multiplyExact(daysPerMonth *
DateTimeUtils.MICROS_PER_DAY, cal.months)
+ val result = Math.addExact(cal.microseconds, monthsDuration)
+ targetUnit.convert(result, TimeUnit.MICROSECONDS)
+ }
+
+ /**
+ * Checks the interval is negative
+ *
+ * @param cal - the checked interval
+ * @param daysPerMonth - the number of days per one month
+ * @return true if duration of the given interval is less than 0 otherwise
false
+ */
+ def isNegative(cal: CalendarInterval, daysPerMonth: Int = 31): Boolean = {
Review comment:
I agree, this isn't specific to one usage. If it lives in a general class a
general name is better
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
