HeartSaVioR commented on a change in pull request #26292: [SPARK-29635][SS]
Extract base test suites between Kafka micro-batch sink and Kafka continuous
sink
URL: https://github.com/apache/spark/pull/26292#discussion_r339958307
##########
File path:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala
##########
@@ -74,21 +78,28 @@ abstract class KafkaSinkSuiteBase extends QueryTest with
SharedSparkSession with
}
}
-class KafkaSinkStreamingSuite extends KafkaSinkSuiteBase with StreamTest {
+abstract class KafkaSinkStreamingSuiteBase extends KafkaSinkSuiteBase {
import testImplicits._
- override val streamingTimeout = 30.seconds
+ protected val streamingTimeout = 30.seconds
+
+ // TODO: this is set to "Int" since ContinuousMemoryStream cannot deal with
String
Review comment:
I might file another issue soon for fixing ContinuousMemoryStream to support
String. There seems to some hurdles to fix that, so I just defer to the another
issue. Please let me know if we want to fix it altogether.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
