Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/4233#discussion_r24055623 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/classification/LogisticRegressionSuite.scala --- @@ -459,7 +461,41 @@ class LogisticRegressionSuite extends FunSuite with MLlibTestSparkContext with M // very steep curve in logistic function so that when we draw samples from distribution, it's // very easy to assign to another labels. However, this prediction result is consistent to R. validatePrediction(model.predict(validationRDD.map(_.features)).collect(), validationData, 0.47) + } + + test("model export/import") { --- End diff -- That requires us to maintain the exporters for each version. I'm thinking of keeping one saved model as test resources and test against that.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org