srowen commented on a change in pull request #26263: [SPARK-29570][WEBUI]
Improve tooltip for Executor Tab for Shuffle Write,Blacklisted,Logs,Threaddump
columns
URL: https://github.com/apache/spark/pull/26263#discussion_r340079573
##########
File path: core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala
##########
@@ -200,10 +200,10 @@ private[ui] class StagePagedTable(
stageHeadersAndCssClasses.map { case (header, tooltip, sortable) =>
val headerSpan = tooltip.map { case (title, left) =>
if (left) {
- /* Place the shuffle write tooltip on the left (rather than the
default position
+ /* Place the shuffle write tooltip on the auto (rather than the
default position
Review comment:
Nit: we need to reword this comment: "Place the tooltip automatically rather
than on top because..."
Actually you don't need the if-else here anymore?
It might be worth double-checking that the auto placement on this element
works well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
