Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4259#discussion_r24056251
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/sharedParams.scala 
---
    @@ -23,6 +23,27 @@ private[ml] trait HasRegParam extends Params {
       def getRegParam: Double = get(regParam)
     }
     
    +private[ml] trait HasElasticNetParam extends HasRegParam {
    +  /** param for elastic net regularization parameter */
    +  val alphaParam: DoubleParam = new DoubleParam(
    +    this, "alphaParam", "the ElasticNet mixing parameter")
    +  def getAlphaParam: Double = get(alphaParam)
    +}
    +
    +private[ml] trait HasConvergenceTol extends Params {
    --- End diff --
    
    In `spark.ml`, we try to use short names for parameters. This could be 
called `tol`, as used in sklearn and matlab.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to