rdblue commented on a change in pull request #26231: [SPARK-29572][SQL] add v1
read fallback API in DS v2
URL: https://github.com/apache/spark/pull/26231#discussion_r340305539
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
##########
@@ -141,7 +138,8 @@ case class RowDataSourceScanExec(
// Don't care about `rdd` and `tableIdentifier` when canonicalizing.
override def doCanonicalize(): SparkPlan =
copy(
- fullOutput.map(QueryPlan.normalizeExpressions(_, fullOutput)),
+ // Only the required column names matter when checking equality.
+ output.map(a => a.withExprId(ExprId(-1))),
Review comment:
Why does this not use `normalizeExpressions`? It seems odd to use a special
case fixed ID here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
