Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/4289#discussion_r24057467
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala ---
@@ -264,15 +268,31 @@ private[hive] object HadoopTableReader extends
HiveInspectors {
* @param nonPartitionKeyAttrs Attributes that should be filled together
with their corresponding
* positions in the output schema
* @param mutableRow A reusable `MutableRow` that should be filled
+ * @param convertdeserializer The `Deserializer` covert the
`deserializer`
* @return An `Iterator[Row]` transformed from `iterator`
*/
def fillObject(
iterator: Iterator[Writable],
deserializer: Deserializer,
nonPartitionKeyAttrs: Seq[(Attribute, Int)],
- mutableRow: MutableRow): Iterator[Row] = {
+ mutableRow: MutableRow,
+ convertdeserializer: Option[Deserializer] = None): Iterator[Row] = {
--- End diff --
Instead of passing the `deserializer`, how about take the `converter` as
the argument? By the way, I think Hive provides the `IdentityConverter`, which
mean we can make the parameter as "ObjectInspectorConverters.Converter", not
necessary wrapped by `Option`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
