JkSelf commented on a change in pull request #26289:
[SPARK-28560][SQL][followup] support the build side to local shuffle reader as
far as possible in BroadcastHashJoin
URL: https://github.com/apache/spark/pull/26289#discussion_r340452202
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/OptimizeLocalShuffleReader.scala
##########
@@ -24,31 +24,33 @@ import
org.apache.spark.sql.catalyst.plans.physical.{Partitioning, UnknownPartit
import org.apache.spark.sql.catalyst.rules.Rule
import org.apache.spark.sql.execution.{SparkPlan, UnaryExecNode}
import org.apache.spark.sql.execution.exchange.{EnsureRequirements,
ShuffleExchangeExec}
-import org.apache.spark.sql.execution.joins.{BroadcastHashJoinExec, BuildLeft,
BuildRight}
import org.apache.spark.sql.internal.SQLConf
case class OptimizeLocalShuffleReader(conf: SQLConf) extends Rule[SparkPlan] {
- def canUseLocalShuffleReaderLeft(join: BroadcastHashJoinExec): Boolean = {
Review comment:
Currently we still implement the rule based on `BroadcastHashJoinExec`, and
will not need to updated the configuration. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
