viirya commented on a change in pull request #26289:
[SPARK-28560][SQL][followup] support the build side to local shuffle reader as
far as possible in BroadcastHashJoin
URL: https://github.com/apache/spark/pull/26289#discussion_r340458747
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/OptimizeLocalShuffleReader.scala
##########
@@ -56,16 +76,25 @@ case class OptimizeLocalShuffleReader(conf: SQLConf)
extends Rule[SparkPlan] {
case e: ShuffleExchangeExec => e
}.length
}
-
+ // Check whether additional shuffle introduced. If introduced, revert the
local reader.
Review comment:
Now this rule converts local shuffle reader for all BroadcastHashJoinExec
and then reverts all local shuffle readers if any of local shuffle reader
causes additional shuffle.
Can we just revert the local shuffle readers that cause additional shuffle
and keep these not?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
