cloud-fan commented on a change in pull request #26289:
[SPARK-28560][SQL][followup] support the build side to local shuffle reader as
far as possible in BroadcastHashJoin
URL: https://github.com/apache/spark/pull/26289#discussion_r340460573
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala
##########
@@ -189,9 +218,32 @@ class AdaptiveQueryExecSuite
assert(smj.size == 3)
val bhj = findTopLevelBroadcastHashJoin(adaptivePlan)
assert(bhj.size == 3)
- // The child of remaining two BroadcastHashJoin is not ShuffleQueryStage.
- // So only two LocalShuffleReader.
- checkNumLocalShuffleReaders(adaptivePlan, 1)
+ // *(7) BroadcastHashJoin [b#24], [a#33], Inner, BuildLeft
Review comment:
It's a bit verbose to put the entire query plan here. How about we only put
the sketch?
```
BroadcastHashJoin
+- BroadcastExchange
+- LocalShuffleReader*
+- ShuffleExchange
+- BroadcastHashJoin
+- BroadcastExchange
+- LocalShuffleReader*
+- ShuffleExchange
+- LocalShuffleReader*
+- ShuffleExchange
+- BroadcastHashJoin
+- LocalShuffleReader*
+- ShuffleExchange
+- BroadcastExchange
+-HashAggregate
+- CoalescedShuffleReader
+- ShuffleExchange
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
