kiszk commented on a change in pull request #26306: [SPARK-29646][BUILD] Allow
pyspark version name format `${versionNumber}-preview` in release script
URL: https://github.com/apache/spark/pull/26306#discussion_r340771141
##########
File path: dev/create-release/release-build.sh
##########
@@ -219,7 +219,7 @@ if [[ "$1" == "package" ]]; then
# Write out the VERSION to PySpark version info we rewrite the - into a .
and SNAPSHOT
# to dev0 to be closer to PEP440.
- PYSPARK_VERSION=`echo "$SPARK_VERSION" | sed -r "s/-/./" | sed -r
"s/SNAPSHOT/dev0/"`
+ PYSPARK_VERSION=`echo "$SPARK_VERSION" | sed -r "s/-/./" | sed -r
"s/SNAPSHOT/dev0/" | sed -r "s/preview/dev0/"`
Review comment:
super nit: How about using `-e` instead of using multiple sed commands if we
have a change to update further.
https://unix.stackexchange.com/questions/33157/what-is-the-purpose-of-e-in-sed-command
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
