LucaCanali commented on a change in pull request #26170: [SPARK-29397][core]
Extend plugin interface to include the driver.
URL: https://github.com/apache/spark/pull/26170#discussion_r340832119
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -165,6 +166,11 @@ private[spark] class Executor(
}
}
+ // Plugins need to load using a class loader that includes the executor's
user classpath
+ private val plugins: Option[PluginContainer] =
Utils.withContextClassLoader(replClassLoader) {
Review comment:
I am not sure that plugins should be loaded at this stage when running in
local mode, maybe only the driver side of the plugin is sufficient in local
mode?
Metrics source registration at this stage, when executed in local mode, will
not get the application id. Other metrics handled in executors.scala are not
registered when running in local mode.
The current implementation of executor plugins sends a "isLocal boolean" via
the pluginContext to handle this case in the plugin logic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
