vanzin commented on a change in pull request #26170: [SPARK-29397][core] Extend
plugin interface to include the driver.
URL: https://github.com/apache/spark/pull/26170#discussion_r340843930
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -165,6 +166,11 @@ private[spark] class Executor(
}
}
+ // Plugins need to load using a class loader that includes the executor's
user classpath
+ private val plugins: Option[PluginContainer] =
Utils.withContextClassLoader(replClassLoader) {
Review comment:
You can check if you're running in local mode by looking at the spark.master
value. I intentionally did not add to the API since it would be redundant.
I'm also not especially worried about local mode. It's mostly for debugging.
If something doesn't work 100% as intended for plugins, I'm totally fine with
it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
