shivsood commented on a change in pull request #25344: [SPARK-28151][SQL]
Mapped ByteType to TinyINT for MsSQLServerDialect
URL: https://github.com/apache/spark/pull/25344#discussion_r340907590
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
##########
@@ -550,7 +550,7 @@ object JdbcUtils extends Logging {
case ByteType =>
(stmt: PreparedStatement, row: Row, pos: Int) =>
- stmt.setInt(pos + 1, row.getByte(pos))
+ stmt.setByte(pos + 1, row.getByte(pos))
Review comment:
Would suggest to keep the PRs seperate. If you think ByteType should be
resolved for other then i can create a separate JIRA and PR for it. Note that
this PR is specifically SQL Server dialect changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
