Github user kayousterhout commented on the pull request:
https://github.com/apache/spark/pull/3779#issuecomment-72800486
Echoing the comments from @markhamstra and @JoshRosen, this change looks
correct but is very subtle, so it would be great to improve the commenting
throughout to avoid confusion for others who read this code later. I suggested
a few comment improvements; if you have time to make these soon, that would be
great since I know you wanted this in for 1.3 and I know the merge window for
that is closing rapidly. Thanks @davies!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
