Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3903#discussion_r24069478
--- Diff:
core/src/main/scala/org/apache/spark/storage/BlockManagerMasterActor.scala ---
@@ -52,11 +52,7 @@ class BlockManagerMasterActor(val isLocal: Boolean,
conf: SparkConf, listenerBus
private val akkaTimeout = AkkaUtils.askTimeout(conf)
- val slaveTimeout = {
- val defaultMs =
math.max(conf.getInt("spark.executor.heartbeatInterval", 10000) * 3, 45000)
- val networkTimeout = conf.getInt("spark.network.timeout", defaultMs /
1000)
- conf.getLong("spark.storage.blockManagerSlaveTimeoutMs",
networkTimeout * 1000)
- }
+ val slaveTimeout =
conf.getLong("spark.storage.blockManagerSlaveTimeoutMs", 120 * 1000)
--- End diff --
I think it's fair to remove the blockManagerSlaveTimeoutMs. The various
timeouts are not useful ... Let me check with others also.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
