viirya commented on a change in pull request #26338: [SPARK-29680][SQL] ALTER
TABLE CHANGE COLUMN should look up catalog/table like v2 commands
URL: https://github.com/apache/spark/pull/26338#discussion_r341278279
##########
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -151,7 +151,7 @@ statement
| ALTER TABLE multipartIdentifier
(ALTER | CHANGE) COLUMN? qualifiedName
(TYPE dataType)? (COMMENT comment=STRING)? colPosition?
#alterTableColumn
- | ALTER TABLE tableIdentifier partitionSpec?
+ | ALTER TABLE multipartIdentifier partitionSpec?
Review comment:
I did not combine two rules and two statements. A possible combine might
have few Option fields and a logic to interpret it to v1/v2 cases, a bit mess
it sounds like.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
