HeartSaVioR commented on a change in pull request #26108: [SPARK-26154][SS]
Streaming left/right outer join should not return outer nulls for already
matched rows
URL: https://github.com/apache/spark/pull/26108#discussion_r341423434
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
##########
@@ -233,16 +263,17 @@ class SymmetricHashJoinStateManager(
// any hole. So we swap the last element into the hole and decrement
numValues to shorten.
// clean
if (numValues > 1) {
- val valueAtMaxIndex = keyWithIndexToValue.get(currentKey, numValues
- 1)
- keyWithIndexToValue.put(currentKey, index, valueAtMaxIndex)
+ val (valueAtMaxIndex, matchedAtMaxIndex) =
keyWithIndexToValue.getWithMatched(currentKey,
Review comment:
Same here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
