viirya commented on a change in pull request #26354: [SPARK-29353][SQL]
Fallback AlterTableAlterColumnStatement to v1 AlterTableChangeColumnCommand
URL: https://github.com/apache/spark/pull/26354#discussion_r341621107
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
##########
@@ -62,8 +62,28 @@ class ResolveSessionCatalog(
nameParts @ SessionCatalog(catalog, tableName), colName, dataType,
comment) =>
loadTable(catalog, tableName.asIdentifier).collect {
case v1Table: V1Table =>
- // TODO(SPARK-29353): we should fallback to the v1
`AlterTableChangeColumnCommand`.
- throw new AnalysisException("ALTER COLUMN is only supported with v2
tables.")
+ if (colName.length > 1) {
+ throw new AnalysisException(
+ "ALTER COLUMN with qualified column is only supported with v2
tables.")
+ }
+ if (dataType.isEmpty) {
+ throw new AnalysisException(
+ "ALTER COLUMN with v1 tables must specify new data type.")
+ }
Review comment:
Alternative option is, we may find out the datatype of given column and just
use it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
