Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/4233#discussion_r24105717
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala
---
@@ -126,6 +137,35 @@ class LogisticRegressionModel (
bestClass.toDouble
}
}
+
+ override def save(sc: SparkContext, path: String): Unit = {
+ GLMClassificationModel.SaveLoadV1_0.save(sc, path,
this.getClass.getName,
+ weights, intercept, threshold)
+ }
+
+ override protected def formatVersion: String = "1.0"
+}
+
+object LogisticRegressionModel extends Loader[LogisticRegressionModel] {
+
+ override def load(sc: SparkContext, path: String):
LogisticRegressionModel = {
+ val (loadedClassName, version, metadata) = Loader.loadMetadata(sc,
path)
+ val classNameV1_0 =
"org.apache.spark.mllib.classification.LogisticRegressionModel"
--- End diff --
Maybe we should put a comment here about why using literal string name.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
