viirya commented on a change in pull request #26365: [SPARK-29720][CORE] Add
linux condition to make ProcfsMetricsGetter more complete
URL: https://github.com/apache/spark/pull/26365#discussion_r341909008
##########
File path:
core/src/main/scala/org/apache/spark/executor/ProcfsMetricsGetter.scala
##########
@@ -62,13 +64,14 @@ private[spark] class ProcfsMetricsGetter(procfsDir: String
= "/proc/") extends L
SparkEnv.get.conf.get(config.EVENT_LOG_STAGE_EXECUTOR_METRICS)
val shouldLogStageExecutorProcessTreeMetrics =
SparkEnv.get.conf.get(config.EVENT_LOG_PROCESS_TREE_METRICS)
- procDirExists.get && shouldLogStageExecutorProcessTreeMetrics &&
shouldLogStageExecutorMetrics
+ procDirExists.get && shouldLogStageExecutorProcessTreeMetrics &&
+ shouldLogStageExecutorMetrics && Shell.LINUX
Review comment:
If /proc in other Unix-like systems, this change actually removes the
support on these systems. Unless we are sure current code does not work for
such systems, I think we should not simply remove their support.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
