srowen commented on a change in pull request #26382:
[SPARK-29738][SPARK-CORE]Add a shutdown hook log wrapper
URL: https://github.com/apache/spark/pull/26382#discussion_r342115164
##########
File path: core/src/main/scala/org/apache/spark/util/ShutdownHookManager.scala
##########
@@ -142,6 +142,7 @@ private[spark] object ShutdownHookManager extends Logging {
addShutdownHook(DEFAULT_SHUTDOWN_PRIORITY)(hook)
}
+ val DEFAULT_HOOK_CALLER_DEPTH = 3
Review comment:
I think this is kind of arbitrary and the result won't be so helpful. Let's
just let callers specify a meaningful string to identify the hook, and then
specify that throughout the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
