squito commented on issue #26284: [SPARK-29415][Core]Stage Level Sched: Add base ResourceProfile and Request classes URL: https://github.com/apache/spark/pull/26284#issuecomment-549416880 Its hard to know how to break down a large change like this. It definitely is helpful to have it in little chunks, and this is a logical unit -- I just have a hard time knowing how the bits fit together, which is why its helpful to at least be able to explore some code with more parts, even if I'm not reviewing it carefully. To me, the key part is understanding how the scheduler is going to put everything together (eg. I left a question on the doc on how Task & Executor requests get combined and whether both are necessary). Its also OK to just amend this part in the future if we realize later we could improve this, as this is all being kept private for now.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
