dongjoon-hyun commented on a change in pull request #26387: [SPARK-29743][SQL]
sample should set needCopyResult to true if its child is
URL: https://github.com/apache/spark/pull/26387#discussion_r342181071
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
##########
@@ -299,7 +299,9 @@ case class SampleExec(
child.asInstanceOf[CodegenSupport].produce(ctx, this)
}
- override def needCopyResult: Boolean = withReplacement
+ override def needCopyResult: Boolean = {
+ child.asInstanceOf[CodegenSupport].needCopyResult || withReplacement
Review comment:
Oh, yes. Indeed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
