rezasafi edited a comment on issue #26365: [SPARK-29720][CORE] Add linux condition to make ProcfsMetricsGetter more complete URL: https://github.com/apache/spark/pull/26365#issuecomment-549471718 I agree with others here. prosfs based systems are not just linux systems ( I have a vague memory that this was discussed when the pr for prosfs metrics was opened) and also this feature isn't enabled by default. But I think we need to add documentation for the config saying that the feature is only working on prosfs based systems. We missed that doc at the time of adding the feature. I mean adding a ".doc" for the config in package.scala
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
