gatorsmile commented on a change in pull request #25914: [SPARK-29227][SS]
Track rule info in optimization phase
URL: https://github.com/apache/spark/pull/25914#discussion_r342387589
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/IncrementalExecution.scala
##########
@@ -77,7 +77,8 @@ class IncrementalExecution(
*/
override
lazy val optimizedPlan: LogicalPlan =
tracker.measurePhase(QueryPlanningTracker.OPTIMIZATION) {
- sparkSession.sessionState.optimizer.execute(withCachedData)
transformAllExpressions {
+ sparkSession.sessionState.optimizer.executeAndTrack(withCachedData,
+ tracker) transformAllExpressions {
Review comment:
nitpit: in most cases, we do not break the function call in the middle of
parameter lists. We can change it to
```Scala
val sessionState = sparkSession.sessionState
sessionState.optimizer.executeAndTrack(withCachedData,
tracker).transformAllExpressions {
```
or
```Scala
sparkSession.sessionState.optimizer
.executeAndTrack(withCachedData, tracker).transformAllExpressions {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
