yaooqinn commented on a change in pull request #26337: [SPARK-29679][SQL] Make
interval type comparable and orderable
URL: https://github.com/apache/spark/pull/26337#discussion_r342392328
##########
File path:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/CalendarInterval.java
##########
@@ -78,6 +81,27 @@ public int hashCode() {
return Objects.hash(months, days, microseconds);
}
+ @Override
+ public int compare(CalendarInterval that) {
+ long thisAdjustDays = this.microseconds / MICROS_PER_DAY + this.days +
this.months * 30;
Review comment:
> How about to extract the code:
>
> ```scala
> var result = interval.microseconds
> result += DateTimeUtils.MICROS_PER_DAY * interval.days
> result += MICROS_PER_YEAR * (interval.months / MONTHS_PER_YEAR)
> result += MICROS_PER_MONTH * (interval.months % MONTHS_PER_YEAR)
> ```
>
> and reuse it in the comparison? At least, we will have consistent behavior.
It not accurate enough for MICROS_PER_YEAR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
