dongjoon-hyun commented on a change in pull request #26320: [SPARK-29654][CORE] 
Add configuration to allow disabling registration of static sources to the 
metrics system
URL: https://github.com/apache/spark/pull/26320#discussion_r342392980
 
 

 ##########
 File path: docs/monitoring.md
 ##########
 @@ -923,13 +923,17 @@ This is the component with the largest amount of 
instrumented metrics
   - memory.remainingOnHeapMem_MB
 
 - namespace=HiveExternalCatalog
+  - **note:**: these metrics are conditional to a configuration parameter:
+    `spark.metrics.register.static.sources.enabled` (default is true) 
   - fileCacheHits.count
   - filesDiscovered.count
   - hiveClientCalls.count
   - parallelListingJobCount.count
   - partitionsFetched.count
 
 - namespace=CodeGenerator
+  - **note:**: these metrics are conditional to a configuration parameter:
+    `spark.metrics.register.static.sources.enabled` (default is true) 
 
 Review comment:
   `Executor` also has the following. I guess this PR aims to control them 
together.
   ```
   - namespace=HiveExternalCatalog
     - fileCacheHits.count
     - filesDiscovered.count
     - hiveClientCalls.count
     - parallelListingJobCount.count
     - partitionsFetched.count
   - namespace=CodeGenerator
     - compilationTime (histogram)
     - generatedClassSize (histogram)
     - generatedMethodSize (histogram)
     - hiveClientCalls.count
     - sourceCodeSize (histogram)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to