MaxGekk commented on a change in pull request #26132: [SPARK-29387][SQL]
Support `*` and `/` operators for intervals
URL: https://github.com/apache/spark/pull/26132#discussion_r342491804
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
##########
@@ -846,6 +848,12 @@ object TypeCoercion {
Cast(TimeAdd(l, r), l.dataType)
case Subtract(l, r @ CalendarIntervalType()) if
acceptedTypes.contains(l.dataType) =>
Cast(TimeSub(l, r), l.dataType)
+ case Multiply(l @ CalendarIntervalType(), r @ NumericType()) =>
+ MultiplyInterval(l, r)
+ case Multiply(l @ NumericType(), r @ CalendarIntervalType()) =>
+ MultiplyInterval(r, l)
+ case Divide(l @ CalendarIntervalType(), r @ NumericType()) =>
Review comment:
Taking into account the discussion in
https://github.com/apache/spark/pull/26165, I am not sure. @cloud-fan Should I
support this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
