davidvrba commented on a change in pull request #26294: [SPARK-28477] [SQL]
Rewrite CaseWhen with single branch to If
URL: https://github.com/apache/spark/pull/26294#discussion_r342792746
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
##########
@@ -435,6 +435,11 @@ object SimplifyConditionals extends Rule[LogicalPlan]
with PredicateHelper {
e.copy(branches = newBranches)
}
+ case e @ CaseWhen(branches, elseValue) if branches.length == 1 =>
Review comment:
Thanks for looking at it! And yes, it does depend on how codegen is
implemented. I will move the logic to `CaseWhen.doGenCode` as you suggest.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
