Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/4216#discussion_r24138163
--- Diff:
core/src/main/scala/org/apache/spark/deploy/rest/StandaloneRestClient.scala ---
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.deploy.rest
+
+import java.io.{DataOutputStream, FileNotFoundException}
+import java.net.{HttpURLConnection, SocketException, URL}
+
+import scala.io.Source
+
+import com.google.common.base.Charsets
+
+import org.apache.spark.{Logging, SPARK_VERSION => sparkVersion}
+import org.apache.spark.deploy.SparkSubmitArguments
+
+/**
+ * A client that submits applications to the standalone Master using a
REST protocol.
+ * This client is intended to communicate with the
[[StandaloneRestServer]] and is
+ * currently used for cluster mode only.
+ *
+ * The specific request sent to the server depends on the action as
follows:
+ * (1) submit - POST to /submissions/create
+ * (2) kill - POST /submissions/kill/[submissionId]
+ * (3) status - GET /submissions/status/[submissionId]
+ *
+ * In the case of (1), parameters are posted in the HTTP body in the form
of JSON fields.
+ * Otherwise, the URL fully specifies the intended action of the client.
+ *
+ * Additionally, the base URL includes the version of the protocol. For
instance:
--- End diff --
I would say "as of v1, versions have the following semantics".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
