vanzin commented on a change in pull request #25964: [SPARK-29287][Core] Add
ExecutorConstructed message to tell driver which executor is ready for making
offers
URL: https://github.com/apache/spark/pull/25964#discussion_r342855890
##########
File path:
core/src/main/scala/org/apache/spark/scheduler/cluster/ExecutorData.scala
##########
@@ -38,5 +39,6 @@ private[cluster] class ExecutorData(
override val totalCores: Int,
override val logUrlMap: Map[String, String],
override val attributes: Map[String, String],
- override val resourcesInfo: Map[String, ExecutorResourceInfo]
+ override val resourcesInfo: Map[String, ExecutorResourceInfo],
+ @volatile var isReady: Boolean = false
Review comment:
Instead of tracking more state, why not keep `freeCores` at 0 until the
message you're adding arrives?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
