maropu commented on a change in pull request #26399: [SPARK-29757][SQL] Move
calendar interval constants together
URL: https://github.com/apache/spark/pull/26399#discussion_r342858908
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala
##########
@@ -397,15 +398,15 @@ class DateTimeUtilsSuite extends SparkFunSuite with
Matchers with SQLHelper {
// transit from Pacific Standard Time to Pacific Daylight Time
assert(timestampAddInterval(
- ts1, 0, 0, 23 * CalendarInterval.MICROS_PER_HOUR, TimeZonePST.toZoneId)
=== ts2)
+ ts1, 0, 0, 23 * IntervalConstants.MICROS_PER_HOUR, TimeZonePST.toZoneId)
=== ts2)
Review comment:
We don't need the prefix `IntervalConstants.` cuz we've already imported
`xxx.IntervalConstants._`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
