fuwhu commented on a change in pull request #26356: [SPARK-29707][SQL] Add
configuration 'spark.sql.maxDataSourceScanMetadataStringLength'
URL: https://github.com/apache/spark/pull/26356#discussion_r342904995
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
##########
@@ -58,7 +58,8 @@ trait DataSourceScanExec extends LeafExecNode {
override def simpleString(maxFields: Int): String = {
val metadataEntries = metadata.toSeq.sorted.map {
case (key, value) =>
- key + ": " + StringUtils.abbreviate(redact(value), 100)
+ key + ": " + StringUtils.abbreviate(redact(value),
Review comment:
@HyukjinKwon
StringUtils.abbreviate is used in the two classes below as well :
FileScan
InMemoryRelation
For FileScan, it's also used to abbreviate metadata, so i think we can use
maxMetadataValueStringLength there as well.
I just update the code, please review again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
