maropu commented on issue #26406: [WIP][SPARK-29145][SQL][FOLLOW-UP] Port in-subquery-on-join-condition.sql URL: https://github.com/apache/spark/pull/26406#issuecomment-550180585 How about moving these tests into `subquery/in-subquery/in-joins.sql` instead of making a new file? Also, I think we need to execute multiple tests runs for these tests with different configurations; ``` --SET spark.sql.autoBroadcastJoinThreshold=10485760 --SET spark.sql.autoBroadcastJoinThreshold=-1,spark.sql.join.preferSortMergeJoin=true --SET spark.sql.autoBroadcastJoinThreshold=-1,spark.sql.join.preferSortMergeJoin=false ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
