AngersZhuuuu commented on a change in pull request #26378:
[SPARK-29724][SPARK-29726][WEBUI][SQL] Support JDBC/ODBC tab for HistoryServer
WebUI
URL: https://github.com/apache/spark/pull/26378#discussion_r343014058
##########
File path:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkGetTablesOperation.scala
##########
@@ -124,17 +126,20 @@ private[hive] class SparkGetTablesOperation(
setState(OperationState.ERROR)
e match {
case hiveException: HiveSQLException =>
- HiveThriftServer2.listener.onStatementError(
- statementId, hiveException.getMessage,
SparkUtils.exceptionString(hiveException))
+
HiveThriftServer2.listener.postLiveListenerBus(SparkListenerStatementError(
+ statementId, hiveException.getMessage,
SparkUtils.exceptionString(hiveException),
+ System.currentTimeMillis()))
throw hiveException
case _ =>
val root = ExceptionUtils.getRootCause(e)
- HiveThriftServer2.listener.onStatementError(
Review comment:
> I think, without posting the events to `LiveListenerBus`,
`EventLoggingListner` won't be able to catch the events, and hence
`Historyserver` won't populate the page
I know the whole process. I mean not change API in Operation classes.
Keep change in ThriftServerListener and post it to ListenerBus
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
