zhengruifeng commented on a change in pull request #26393: [SPARK-29751][ML]
Scalers use Summarizer instead of MultivariateOnlineSummarizer
URL: https://github.com/apache/spark/pull/26393#discussion_r343021314
##########
File path: mllib/src/main/scala/org/apache/spark/ml/feature/MaxAbsScaler.scala
##########
@@ -69,14 +68,13 @@ class MaxAbsScaler @Since("2.0.0") (@Since("2.0.0")
override val uid: String)
@Since("2.0.0")
override def fit(dataset: Dataset[_]): MaxAbsScalerModel = {
transformSchema(dataset.schema, logging = true)
- val input = dataset.select($(inputCol)).rdd.map {
- case Row(v: Vector) => OldVectors.fromML(v)
- }
- val summary = Statistics.colStats(input)
Review comment:
After this PR, `Statistics.colStats` is no longer directly used in the `.ml`
side.
It is still used in `mllib.PCA`, which is the impl of `ml.PCA`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
