cloud-fan commented on a change in pull request #26410:
[SPARK-29387][SQL][FOLLOWUP] Fix issues of the multiply and divide for intervals
URL: https://github.com/apache/spark/pull/26410#discussion_r343024739
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/intervalExpressions.scala
##########
@@ -137,7 +139,11 @@ abstract class IntervalNumOperation(
val iu = IntervalUtils.getClass.getName.stripSuffix("$")
s"""
try {
- ${ev.value} = $iu.$operationName($interval, $num);
+ if ($num != 0) {
+ ${ev.value} = $iu.$operationName($interval, $num);
+ } else {
+ ${ev.isNull} = true;
Review comment:
is this needed? divide by 0 throws ArithmeticException and we return null
already.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
