shahidki31 commented on issue #26378: [SPARK-29724][SPARK-29726][WEBUI][SQL] Support JDBC/ODBC tab for HistoryServer WebUI URL: https://github.com/apache/spark/pull/26378#issuecomment-550295455 > Actually, let's think a bit more about it. > Normal listeners work by getting events from the live listener bus, not be called directly. So maybe it's better to make it behave the same way and also post events? > The only argument against it is that the listener bus can drop events if it becomes to busy, but the same argument applies for other Spark UI events. Making it be fully events driven, like in this PR, makes it consistent with all other SparkListeners. Thanks @juliuszsompolski for the comment. Yes, I followed similar to the other existing listeners here. Only difference is that, posting the events to the listener bus from the listener itself, using the `SparkContext` that passed from the `HiveThriftServer2`. Also, the frequency of `Thriftserver events` is relatively very low compared to the `TaskEvents` or `JobEvents`. But, without that the events we can't populate the UI from HistoryServer.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
