shahidki31 commented on a change in pull request #26378:
[SPARK-29724][SPARK-29726][WEBUI][SQL] Support JDBC/ODBC tab for HistoryServer
WebUI
URL: https://github.com/apache/spark/pull/26378#discussion_r343105806
##########
File path:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkGetTablesOperation.scala
##########
@@ -124,17 +126,20 @@ private[hive] class SparkGetTablesOperation(
setState(OperationState.ERROR)
e match {
case hiveException: HiveSQLException =>
- HiveThriftServer2.listener.onStatementError(
- statementId, hiveException.getMessage,
SparkUtils.exceptionString(hiveException))
+
HiveThriftServer2.listener.postLiveListenerBus(SparkListenerStatementError(
+ statementId, hiveException.getMessage,
SparkUtils.exceptionString(hiveException),
+ System.currentTimeMillis()))
throw hiveException
case _ =>
val root = ExceptionUtils.getRootCause(e)
- HiveThriftServer2.listener.onStatementError(
Review comment:
> 👍 to @AngersZhuuuu suggestion. To avoid changes in the operation classes,
you could call keep calling the onFooBar functions directly there, and then if
(live) { postLiveListenerBus(createEvent) } from there.
I have updated based on the above comment. Now, the operation classes won't
have any changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
