srowen commented on a change in pull request #26138: [SPARK-29456][WebUI]
Improve tooltip for Session Statistics Table column in JDBC/ODBC Server Tab
URL: https://github.com/apache/spark/pull/26138#discussion_r343149342
##########
File path:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ToolTips.scala
##########
@@ -29,4 +29,16 @@ private[ui] object ToolTips {
val THRIFT_SERVER_DURATION =
"Difference between start time and close time"
+
+ val THRIFT_SESSION_TOTAL_EXECUTE =
+ "Number of operations submitted in this session."
+
+ val THRIFT_SESSION_START_TIME =
+ "Session Start time,on launching the session."
+
+ val THRIFT_SESSION_FINISH_TIME =
+ "Session end time, after closing the session."
+
+ val THRIFT_SESSION_DURATION =
+ "Active duration of the session."
Review comment:
I don't think we need tooltips for every single column. "IP of the session"
does not add anything over the column name. We should only add tooltips where
they add something meaningful, like, clarifying for duration fields what the
start and end time are exactly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
