gatorsmile commented on a change in pull request #26400: [SPARK-29759][SQL]
LocalShuffleReaderExec.outputPartitioning should use the corrected attributes
URL: https://github.com/apache/spark/pull/26400#discussion_r343216963
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/ReduceNumShufflePartitions.scala
##########
@@ -182,13 +182,13 @@ case class ReduceNumShufflePartitions(conf: SQLConf)
extends Rule[SparkPlan] {
}
case class CoalescedShuffleReaderExec(
- child: QueryStageExec,
+ // `child` is usually `ShuffleQueryStageExec` or `ReusedQueryStageExec`,
but can be the shuffle
+ // exchange node during canonicalization.
Review comment:
https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/SortExec.scala#L32-L39
We can add descriptions for this case class. It will look more formal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
